Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: changefeedccl: Add jitter to aggregator flushes #114748

Merged
merged 1 commit into from
Nov 21, 2023
Merged

release-23.1: changefeedccl: Add jitter to aggregator flushes #114748

merged 1 commit into from
Nov 21, 2023

Conversation

miretskiy
Copy link
Contributor

Backport 1/1 commits from #114161.

/cc @cockroachdb/release

Backport defaults changefeed.aggregator.flush_jitter to 0 (disabled).
Release justification: scalability improvement

Add jitter, controlled by the changefeed.aggregator.flush_jitter
setting (default 10%) to the aggregator flush logic.
This helps mitigate the load place on the changefeed coordinator
by spreading out the time aggregators decide to flush.

Informs #114133

Release note: None

changefeedccl: Add jitter to aggregator flushes
02cfc2b 
Add jitter, controlled by the `changefeed.aggregator.flush_jitter`
setting (default 10%) to the aggregator flush logic.
This helps mitigate the load place on the changefeed coordinator
by spreading out the time arregators decide to flush.

Informs cockroachdb#114133

Release note: None
@miretskiy miretskiy requested review from dt, sean- and nicktrav November 20, 2023 19:46
@miretskiy miretskiy requested a review from a team as a code owner November 20, 2023 19:46
@miretskiy miretskiy requested review from jayshrivastava and removed request for a team November 20, 2023 19:46
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 20, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sean-
sean- approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@sean- sean- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dt, @jayshrivastava, and @nicktrav)

-- commits line 5 at r1:
Isn't this value disabled by default in the backport?

miretskiy
miretskiy commented Nov 20, 2023
View reviewed changes
Copy link
Contributor Author

@miretskiy miretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dt, @jayshrivastava, and @nicktrav)

-- commits line 5 at r1:

Previously, sean- (Sean Chittenden) wrote…

Isn't this value disabled by default in the backport?

yes, it is in the backport, but I didn't change the original PR description.

@miretskiy miretskiy merged commit df99abe into cockroachdb:release-23.1 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean- sean- sean- approved these changes

@dt dt Awaiting requested review from dt

@nicktrav nicktrav Awaiting requested review from nicktrav

@jayshrivastava jayshrivastava Awaiting requested review from jayshrivastava jayshrivastava is a code owner automatically assigned from cockroachdb/cdc-prs

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miretskiy @cockroach-teamcity @sean-